Ticket #676 (closed bug: fixed)

Opened 2 years ago

Last modified 2 years ago

madshelf: treat blank tags as absent

Reported by: t3d Owned by: dottedmag
Priority: normal Milestone: 0.2
Component: bookshelf (MadShelf) Version: post-0.1 snapshot
Keywords: Cc:
Blocked By: Blocking:

Description

rtf file has a blank description in madshelf- no title, no filename, just a number, filesize and 'rtf'.

 http://rapidshare.com/files/85882507/Clancy_Tom_-_Przygody_Jacka_Ryana_05_-_Czerwony_krolik.rtf

Attachments

Clancy_Tom_-_Przygody_Jacka_Ryana_05_-_Czerwony_krolik.rtf Download (2.0 MB) - added by t3d 2 years ago.

Change History

comment:1 Changed 2 years ago by javitonino

Could you please upload the file to another site? It wouldn't let me download unless I'm premium (at least all times I tried it complained about too many users and proposed waiting or getting an account).

comment:2 Changed 2 years ago by javitonino

The file doesn't appear to contain any metadata regarding title or authors. The raw section of the file:

{\info{\title }{\author }{\operator YY}{\creatim\yr2004\mo9\dy3\hr15\min32}{\revtim\yr2005\mo2\dy11\hr14\min50}{\version6} {\edmins16}{\nofpages474}{\nofwords172630}{\nofchars1035784}{\*\company iLLUMiNATiON 2004}{\nofcharsws1206002}{\vern16389}}

Do any other viewer show any metadata?

Maybe we could detect an empty title an use the filename if it is not present to avoid showing empty lines on the bookshelf?

comment:3 follow-up: ↓ 4 Changed 2 years ago by dottedmag

Just don't emit tag if it is not present in file, and it will be handled properly.

comment:4 in reply to: ↑ 3 Changed 2 years ago by javitonino

Replying to dottedmag:

Just don't emit tag if it is not present in file, and it will be handled properly.

It's present, just empty (title = " " a single space). A whitespace trimming should do, but I don't know if it's better to have this at library or plugin level.

comment:5 Changed 2 years ago by dottedmag

Hmm... Let's treat empty tags as absent in madshelf.

comment:6 Changed 2 years ago by dottedmag

  • Owner set to dottedmag
  • Priority changed from critical to normal
  • Component changed from misc to bookshelf (MadShelf)
  • Summary changed from libextractor and rtf: blank description in madshelf to madshelf: treat blank tags as absent

comment:7 Changed 2 years ago by dottedmag

  • Milestone changed from 0.2 to bluesky

comment:8 Changed 2 years ago by dottedmag

  • Status changed from new to closed
  • Resolution set to fixed
  • Milestone changed from bluesky to 0.2

Fixed in madshelf 0.2.40 and libextractor-mini 0.2-8

Note: See TracTickets for help on using tickets.